Open Hub
Open Hub

 Settings

1
I Use This!
Very High Activity

Commits : Listings

Analyzed about 23 hours ago. based on code collected 2 days ago.
Nov 06, 2025 — Nov 06, 2026
Commit Message Contributor Files Modified Lines Added Lines Removed Code Location Date
Remove warning
gefeili
More... 3 months ago
Remove ML-DSA, ML-KEM and SLH-DSA from pqc.crypto.util's ASN.1 codec dispatch (Utils, PublicKeyFactory, PrivateKeyFactory, PrivateKeyInfoFactory, SubjectPublicKeyInfoFactory - base tree and the jdk1.1/jdk1.4 legacy-build overlays), since org.bouncycastle.crypto.util already covers all three OID sets identically and is the path the modern JCE key classes actually use. Also drops the dead kyber512/768/1024_aes-to-MLKEMConverter registration in PublicKeyFactory (its backing OID lookup was never populated, so it could never have resolved) and the now-unreachable SLHDSAParameters-keyed entries in Utils' sphincsPlusOids map (a stale leftover from before SPHINCS+ and SLH-DSA had separate parameter classes - the live sphincsPlusOidLookup only ever takes an SPHINCSPlusParameters key). Removes the two pqc.crypto.util round-trip tests added earlier this session for ML-DSA and SLH-DSA, since that dispatch path no longer recognises either algorithm's OIDs.
gefeili
More... 3 months ago
Remove the ML-KEM branch from pqc.crypto.util.PQCOtherInfoGenerator.PartyU/PartyV, as ML-KEM's OtherInfo generation is already covered by org.bouncycastle.crypto.util.OtherInfoGenerator; only NTRU remains here now, so the constructor parameter reverts from CipherParameters back to org.bouncycastle.pqc.crypto.KEMParameters (which NTRUParameters, unlike the canonical MLKEMParameters, still implements).
gefeili
More... 3 months ago
Complete the SLH-DSA removal from the previous commit: repoint pqc.crypto.util's key-factory classes (base + jdk1.1 + jdk1.4 overlays) to the canonical org.bouncycastle.crypto classes, trim SLHDSATest's now-redundant deprecated-side checkInitGuards calls and add its pqc.crypto.util factory round trip, fix the two package-info cross-references, remove the module-info exports, and add the release note. A scripted git add aborted on an already-staged path before reaching these files, so the prior commit shipped only the file deletions.
gefeili
More... 3 months ago
As announced in the 1.85 release notes, remove the deprecated SLH-DSA implementation under org.bouncycastle.pqc.crypto.slhdsa (public API and its internal engine, plus the jdk1.1-overlay Fors/HT pair that existed only to override files in that package), repointing the pqc.crypto.util key-factory classes - its only remaining production callers - to the canonical org.bouncycastle.crypto.params / generators / signers classes, trimming the now-redundant deprecated-vs-canonical checkInitGuards calls in SLHDSATest, and adding the SLH-DSA round trip through pqc.crypto.util.{PublicKeyFactory,PrivateKeyFactory,PrivateKeyInfoFactory,SubjectPublicKeyInfoFactory}, which had no test coverage of any kind - deprecated or canonical - before this.
gefeili
More... 3 months ago
As announced in the 1.85 release notes, remove the deprecated ML-KEM implementation under org.bouncycastle.pqc.crypto.mlkem (public API and its internal engine), repointing the pqc.crypto.util key-factory classes and pqc.crypto.util.PQCOtherInfoGenerator - its only remaining production callers - to the canonical org.bouncycastle.crypto.params / generators / kems classes. PQCOtherInfoGenerator.PartyU/PartyV widen their constructor parameter from the pqc-side KEMParameters marker interface to CipherParameters, since the canonical MLKEMParameters does not implement that marker interface (only NTRUParameters, which stays under pqc.crypto, still does) - the two markers were never used for anything but instanceof dispatch to the already-narrowed concrete type. Also adds the ML-KEM round trip through PQCOtherInfoGenerator, which had no test coverage of any kind before this.
gefeili
More... 3 months ago
As announced in the 1.85 release notes, remove the deprecated ML-DSA implementation under org.bouncycastle.pqc.crypto.mldsa (public API and its internal engine), repointing the pqc.crypto.util key-factory classes and cert.plants.bc.BcMTCSigners - its only remaining production callers - to the canonical org.bouncycastle.crypto.params / generators / signers classes, and adding the ML-DSA round trip through pqc.crypto.util.{PublicKeyFactory,PrivateKeyFactory,PrivateKeyInfoFactory,SubjectPublicKeyInfoFactory} that had, until now, only ever been exercised through the deprecated classes.
gefeili
More... 3 months ago
Raise InvalidKeyException, rather than let a foreign provider's unchecked exception escape, when a signature, cipher or key-agreement service is initialised with a private key whose parameters are not accessible - a hardware-backed key whose getModulus/getX/getS/getParams throws - across the RSA, DSA, EC, DH and ElGamal key-parameter helpers, relates to github #1440.
David Hook
More... 3 months ago
Fix javadoc doclint issues across core, pg, pkix and prov: broken and cross-module @link references, an invalid wildcard member link, unescaped '<' text, a malformed <a href> tag, stale @param names, an @implNote tag doclint doesn't recognise, a nested-class link naming the wrong enclosing type, an @deprecated tag in package documentation, and a self-closing <p/>
gefeili
More... 3 months ago
Add the missing @Deprecated annotation to nine members already carrying a javadoc @deprecated tag, clearing javac's [dep-ann] warning for each
gefeili
More... 3 months ago
Add an AnimalSniffer Android API level 26 compatibility gate to the Gradle build, checking each published module's base classes against the Android 8.0 platform signature and failing on a java/javax platform API absent there - the class of regression behind github #2369 - with a per-module allow-list for the intentionally platform-absent references (the optional JNDI fetchers and the legacy bcmail java.awt DataFlavor), based on the initial implementation in github #336.
David Hook
More... 3 months ago
Fix test error messages
Peter Dettman
More... 3 months ago
Fix the Error Prone issues in the misc examples: unescape the HTML entities inside two {@code} javadoc tags so the angle brackets render literally rather than as &lt;/&gt;, and make SamplingEntropySourceProvider's DevRandomChainedSource a static nested class since it never references its enclosing instance.
David Hook
More... 3 months ago
Rename the QRUOV PRG helper from yield to yieldBytes so its name no longer collides with the switch-expression contextual keyword, clearing the Error Prone NamedLikeContextualKeyword warning.
David Hook
More... 3 months ago
Turn off the Error Prone StringCharset and AssignmentExpression checks: StringCharset's fix needs the Charset/StandardCharsets overloads barred by the Java 4 source floor (and asn1.eac's CertificateHolderReference has no overlay to shield the legacy builds), and AssignmentExpression's hits are deliberate switch-on-read and constraint-driven super-argument idioms.
David Hook
More... 3 months ago
Correct the MTCCertAuth class javadoc link to authorityInfo, which takes two BigInteger bounds rather than one, so the reference resolves and clears the Error Prone InvalidLink warning.
David Hook
More... 3 months ago
Suppress Error Prone DuplicateBranches on the three methods whose identical branches are deliberate - the DSTU4145 and des-EDE3 TODO placeholders and the raVerified ProofOfPossession default - keeping the check on to catch genuine copy-paste branches elsewhere.
David Hook
More... 3 months ago
Turn off the Error Prone RedundantControlFlow check: its hits are deliberate skip markers - documented continue-on-skip branches, instanceof-chain marker guards and try-next catch blocks - plus third-party Apache bzip2 code kept aligned with upstream, none of which read as misleading and whose removal would leave empty blocks or drop intent.
David Hook
More... 3 months ago
Make the SLHDSA private-key seed holders and the enveloped-data stream generators' output streams static nested classes, since none reference their enclosing instance, clearing the Error Prone ClassCanBeStatic warnings.
David Hook
More... 3 months ago
Turn off the Error Prone BooleanLiteral and IgnoredPureGetter checks: BooleanLiteral's only hits are deliberate boxed Boolean constants whose literal form would need autoboxing the Java 4 source floor rejects, and IgnoredPureGetter fires solely on generated protobuf writeTo memoization that cannot be annotated.
David Hook
More... 3 months ago
Decode the MLS codec enums through a public fromValue lookup keyed on each constant's wire value instead of values() ordinal indexing, leaving the GREASE ordinal-offset branches as the sole EnumOrdinal exceptions.
David Hook
More... 3 months ago
Turn off the Error Prone InlineMeSuggester check, which fires on BouncyCastle's deprecated forwarding methods and can only be satisfied by adding @InlineMe from error_prone_annotations - a dependency the zero-dependency provider will not take, for a Google inliner its consumers do not run.
David Hook
More... 3 months ago
Give CryptoServicePurpose an explicit code, equal to its current ordinal, and read and write a digest's encoded-state purpose byte through getCode/forCode rather than ordinal()/values()[index], so reordering the enum no longer changes the encoded-state format.
David Hook
More... 3 months ago
Merge branch 'main' of gitlab.cryptoworkshop.com:root/bc-java
David Hook
More... 3 months ago
BCJSSE: Only compute active early key shares for TLS 1.3+ clients
Peter Dettman
More... 3 months ago
Turn off the Error Prone EffectivelyPrivate check, which fires only on redundant public/protected modifiers of members already confined by a private or anonymous enclosing class - cosmetic findings that do not fit the deliberately broad public surface, matching the other checks disabled here.
David Hook
More... 3 months ago
BCJSSE: Warn if early key shares configured but none are usable
Peter Dettman
More... 3 months ago
Share one extractor across a FrodoKEM or NTRU+ KEM decapsulator's calls now that the engines build their SHAKE instance per call, rather than constructing a new extractor on every decapsulate, matching the other KEM decapsulators.
David Hook
More... 3 months ago
Merge the FrodoKEM and NTRU+ engine thread-safety fix (build the SHAKE instance per call rather than holding one in a field).
David Hook
More... 3 months ago
Merge the shared KEM secret-key derivation helper (KdfUtil.makeSecretKey) and javax.crypto.KEM support for NTRU LPRime, NTRU+ and SMAUG-T, completing the BCPQC KEM services.
David Hook
More... 3 months ago