Apache HttpComponents

ok2c commented on code in PR #677: URL: https://github.com/apache/httpcomponents-client/pull/677#discussion_r2209974667 ########## httpclient5/src/test/java/org/apache/hc/client5/http/impl/TestDefaultRedirectStrategy.java: ########## @@ -261,13 Read more

dani0600 commented on code in PR #677: URL: https://github.com/apache/httpcomponents-client/pull/677#discussion_r2209966110 ########## httpclient5/src/test/java/org/apache/hc/client5/http/impl/TestDefaultRedirectStrategy.java: ########## @@ -261,13 Read more

Apache HttpClient removes the `Content-Length` header from a DELETE request even when the request has a body and the header is explicitly set.

LaxRedirectStrategy unintentionally blocks redirects due to inherited sensitive header check

dani0600 commented on PR #676: URL: https://github.com/apache/httpcomponents-client/pull/676#issuecomment-3073835377 Thanks a lot, @arturobernalg, for taking care of this so quickly! We really appreciate your responsiveness and the continued Read more

wherka-ama commented on PR #676: URL: https://github.com/apache/httpcomponents-client/pull/676#issuecomment-3073658895 @arturobernalg : it's really refreshing to see how quickly you've managed to sort out this regression. I'm sure many people Read more

Summary: LaxRedirectStrategy in HttpClient 5.5 does not override isRedirectAllowed(), causing unexpected redirect blocking due to inherited sensitive header checks. Description: Starting with HttpClient 5.5, a new check was introduced in RedirectStrategy.isRedirectAllowed() Read more

anasquazbary HttpClient of all versions DOES NOT remove any request headers explicitly set by the caller by default, ever. if Content-Length or Transfer-Encoding has been explicitly set by the caller HttpClient will refuse to execute the request [1]. Read more

HI anasquazbary  IMO this doesn't look like t a bug in Apache HttpClient—it’s exactly what the HTTP/1.1 spec tells you to do: According to [RFC 7230  3.3.2|http://example.com], framing (i.e. whether you send a body) is dictated by your method’s Read more

davsclaus  This change-set [1] will make both classic and async client transports log request re-executions at INFO priority and hopefully should fix the problem you have reported. Please do feel free to take a look and let me know if the fix looks Read more