Apache HttpComponents

ok2c commented on code in PR #680: URL: https://github.com/apache/httpcomponents-client/pull/680#discussion_r2218341837 ########## httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java: ########## @@ -237,6 +237,9 Read more

snehanie  when you have a chance could you give the latest patch a spin? The proxy-lookup has been moved entirely into SystemDefaultRoutePlanner: if the active ProxySelector says “direct”, the planner now consults the usual environment variables—HTTP_PROXY Read more

ok2c commented on PR #680: URL: https://github.com/apache/httpcomponents-client/pull/680#issuecomment-3094643798 @arturobernalg Actually I think it misplaced. This logic should go into `SystemDefaultRoutePlanner` and our code must not change the Read more

ability to expect-continue only if potentially stale

arturobernalg commented on code in PR #680: URL: https://github.com/apache/httpcomponents-client/pull/680#discussion_r2217300779 ########## httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java: ########## @@ Read more

ok2c commented on code in PR #681: URL: https://github.com/apache/httpcomponents-client/pull/681#discussion_r2217232696 ########## httpclient5/src/main/java/org/apache/hc/client5/http/async/methods/DecompressingAsyncEntityConsumer.java: ########## @@ -0,0 +1,102 @@ Read more

ok2c commented on PR #679: URL: https://github.com/apache/httpcomponents-client/pull/679#issuecomment-3090106294 > What's the context here? What problem are you trying to solve? @rschmitt `HttpRequestRetryStrategy` got out of hands. It Read more

ok2c commented on code in PR #680: URL: https://github.com/apache/httpcomponents-client/pull/680#discussion_r2216502806 ########## httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java: ########## @@ -838,6 Read more

arturobernalg commented on code in PR #680: URL: https://github.com/apache/httpcomponents-client/pull/680#discussion_r2216440598 ########## httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java: ########## @@ Read more

ok2c commented on code in PR #680: URL: https://github.com/apache/httpcomponents-client/pull/680#discussion_r2216229648 ########## httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java: ########## @@ -838,6 Read more