Forums : Technical Issue Help
Dear Open Hub Users,
We’re excited to announce that we will be moving the Open Hub Forum to
https://community.blackduck.com/s/black-duck-open-hub.
Beginning immediately, users can head over,
register,
get technical help and discuss issue pertinent to the Open Hub. Registered users can also subscribe to Open Hub announcements here.
On May 1, 2020, we will be freezing https://www.openhub.net/forums and users will not be able to create new discussions. If you have any questions and concerns, please email us at
[email protected]
Excluding files gives strange results
Hi,
I've added some ignore filters to SallyCMS, but the results Ohloh now creates are totally off.
https://www.ohloh.net/p/sallycms/analyses/latest
It seems that way too many PHP files were excluded. Could you take a look into this issue? Just the sally/include/views/addon/list.phtml contains more than the reported 20 lines of HTML code.
Greetings,
Christoph
I can affirm there are issues with the exclusion: I seem to have the opposite phenomenon with exclusions than yours.
On the Edit Enlistment Settings
, it clearly states some (correct) examples for exclusion.
https://www.ohloh.net/p/SoundComp/enlistments/244105/edit
But on the Enlistments
page, it states All files included.
https://www.ohloh.net/p/SoundComp/enlistments
And from the numbers I see, the latter appears to be what actually happens (I wanted to exclude a large bulk of xml files that are not part of the real project sources. Still, I get 20% XML counted, as it was before I added the exclusions). I cannot force it to actually exclude anything. And yes, the last update is much newer than the edited exclusion settings, so it had several chances to exclude files.
Can it be that the exclusion settings only apply to files added AFTER the setting was made, and older files that were actually in because one once forgot to exclude them, are never taken out again?
@Christoph - I've recreated the report on my local development machine, and it looks correct locally. The report which is online right now shows some negative line counts, which makes me believe that the online report woud be erroneous even without the excluded files. Probably, Ohloh's database is hanging on to some old, buggy results. I'm investigating.
@jssr67 - You'll be next up as soon as I finish with SallyCMS :-)
Thanks for your patience,
Robin
@Christoph - I've confirmed that the Ohloh database still has some old, buggy data that needs to be cleaned up.
In February we made some important fixes to the line counter. Unfortunately, the fix requires that we perform a full recount for every project in our database, and this work is still ongoing.
I've scheduled SallyCMS for a full recount, which should happen sometime today.
@jssr67 - I've figured out what the problem is.
In this case, the issue can be resolved by inserting a leading '/' on each of the paths you wish to have excluded. If you look at the example filenames on the form, you will see that the examples all have a leading '/'.
Why? Well, because the enlistment URL + the excluded filename must yield a valid URL. For this project, you'll see that the enlistment URL does not end with a '/', and so if the filenames do not begin with a '/', then the URL + the filename will be missing a necessary '/'.
This is something we should fix. I'll open a bug ticket.
In the mean time, I've taken the liberty to add a preceding '/' to the ignore settings for this project, which should clear up the problem. Let me know if the report still looks incorrect once this change goes through.
Thanks for letting us know about this,
Robin
Robin: Thanks for the explanation, how does it work for git and the like?
E.g.
git://github.com/mediacore/mediacore.git master
Disallow: /mediacore/public/scripts/third-party/
Is that ok?
Can I work around the issue by always starting 'Disallow' lines by '/'? E.g. http://svn.edgewall.com/repos/trac/trunk//foo is fine?
Thank you Robin,
it seems now it does its job.
Several XML files, and the third party C library, are no longer counted, so the Java part is (correctly) the vast majority of the project. I'll add the rest of XML exclusions now.
The main problem was that your examples all excluded the initial '/' - so I got the impression it shouldn't be there. Maybe you don't really need a code fix, just a better documentation of the feature regarding having initial '/' or not :-)
@Felix - For git and the like, do not use a leading '/'. The leading '/' is necessary for Subversion only.
@jssr67 - Yes, the examples don't include a leading '/', and that's simply an oversight on my part. For every source control system except Subversion, the examples are correct. Subversion puts a leading '/' on filenames in its log, so that is how they are stored in the Ohloh DB. I'm sorry to have caused all the confusion.
I'm hoping that it will be an easy fix to make Ohloh to do the right thing whether or not the initial '/' is present. Otherwise, we may indeed have to provide alternate instructions for Subversion.