Forums : Ohloh General Discussion
Dear Open Hub Users,
We’re excited to announce that we will be moving the Open Hub Forum to
https://community.blackduck.com/s/black-duck-open-hub.
Beginning immediately, users can head over,
register,
get technical help and discuss issue pertinent to the Open Hub. Registered users can also subscribe to Open Hub announcements here.
On May 1, 2020, we will be freezing https://www.openhub.net/forums and users will not be able to create new discussions. If you have any questions and concerns, please email us at
[email protected]
Ohcount's BSD license detection is crazy
So, I was looking at the source to ohcount to see why it was detecting all my projects (e.g. https://www.ohloh.net/p/jgrmsts) as BSD Copyright
instead of New BSD License
and I read licenses.c. Oh my, that's got some crazy stuff in.
Let's start with LICBSD, which is has the nicename New BSD license
. That should be BSD Copyright
to go with the website, no? I'm pretty sure it's not the new
one at all. The URL of http://www.opensource.org/licenses/bsd-license.php
is suspect too, that's the New BSD License too, not the original 4-clause one Ohloh is using for LICBSD. The regexp is suspect as well, picking anything containing bsd license
without excluding anything (or having, say, LICBSD_ISH override it).
Now, for LICBSDISH, the URL is blank and the nicename is just BSD-ish License
unlike the website (New BSD License
). The regexp doesn't even attempt to recognise new bsd license
as LICBSD_ISH, too, instead requiring most of the license text.
I'm less sure about LICBSD2CLAUSE_ISH license but its regexp again only matches a significant extract of the license text, which is less than ideal.
If I can conjour up my build environment for ohcount again (I'm on Windows, it was a bit of a challenge to get it building), would you be willing to review a patch to fix the issues above?
Edit: OK, so markdown is appalling. Sigh. I have no idea how to stop it shitting all over the underscores. Why on earth is italic not italic at all, too? That's just weird.
