Slicer4

BUG: reduce message noise When adding a storable node to the scene after a scene view has been added, make sure that only nodes that are saved with the scene generate the warning. Cleaned up debugging messages by changing warning to debug macros. Issue #3956

BUG: double check for dot preceding file suffixes GUI testing showed that renaming a node could lead to a file name of label..nrrd, this fix only adds the leading dot if the complete Slicer writable suffix call doesn't start with it. Issue# 3956

COMP: fix test name for label Configuration was failing with the previous name for the new scripted self test. Issue #3956

ENH: test adding storable data after a scene view is created Add a fiducial, store a scene view, add a volume, restore the scene view. To conform with the current implmentation, the new storable node should not be present after the scene view is ... [More] restored. The test pops up an info window which times out after 15s (needed during run time to let the user read it). Issue #3956 [Less]

ENH: factor out adding data io to the scene Encapsulated setting up the remote IO logic and the data manager IO in the application so that it can work as an example template. Moved the hooking up of the data logic to the scene to the application ... [More] logic so that it can be called by classes with access to the application logic, and use it in the volumes logic for the mini scene. Added some comments to direct developers to the places they need to look to hook up a mini scene that can do data management both locally and remotely. Issue #3956 [Less]

BUG: add support for remote IO The crop volume module self test uses remote data, it was failing with the mini scene in volumes logic until all the pieces were added in to support remote IO. TBD: update the infrastructure to make this more modular, test without batch processing flags. Issue #3956

BUG: use a mini scene for volume loading The volumes logic was adding in multiple volume, display, storage nodes as it tries to load a file. This generated lots of node added/removed events so it was placed inside of a batch processing state for the ... [More] scene. This leads to no node added event after the batch processing end event so the warning about adding new storable nodes to the scene after a scene view is already present wasn't getting triggered. This change uses a mini test scene to try loading data (borrowing the main scene cache manager in case the data is remote) and then adding the successful set of volume nodes to the main scene, with an extra node added event after batch processing ends. Issue #3956 [Less]

BUG: warn the user when they add storable data after scene views When a storable node is added to the scene after scene views, warn the user that restoring a scene view will lose the newly added data. To avoid too many pop ups, don't warn during batch processing. Issue #3956

BUG: function name clarification, add getting readable extensions Thanks to comments from JC: Renamed completeSlicerSuffix to ompleteSlicerWritableFileNameSuffix in order to make it explicit that this was only checking writable extensions. Renamed ... [More] allFileExtensions to allWritableFileExtensions to be more clear as well as adding the equivalent call for readable extensions, allReadableFileExtensions Issue #3956 [Less]

BUG: implement a Slicer specific Qt file suffix In the MRML storage node it is dealing correctly with tricky file names like brain.1.nii.gz to return the proper suffix. In Qt we were relying on completeSuffix but that was returning everything after ... [More] the first dot in the file name and would fail on that example case. This change leverages the storage nodes to gather a list of valid file suffixes and compares them against the file name endings and returns a matching one. Special case included if .* is a valid Slicer suffix, that goes back to Qt's completeSuffix call. Note: tried calling fileWriterExtensions and ran into a crash as it was trying to add new storage nodes to the scene. Use the new suffix in the save data dialog and node writer. Added testing, more file name cases can be added easily. Issue #3956 [Less]