Posted
over 16 years
ago
by
jonasbn-Rn4VEauK AKRv LV9MX5uipxlwaOVQ5f< at >public.gmane.org
Revision: 413
http://perl-workflow.svn.sourceforge.net/perl-workflow/?rev=413&view=rev
Author: jonasbn
Date: 2008-12-20 16:52:22 0000 (Sat, 20 Dec 2008)
Log Message:
-----------
made constants out of some of the hardcoded
... [More]
, addressing Perl::Critic policy [ValuesAndExpressions::ProhibitMagicNumbers]
Some of the constants are candidates for propagation into a central package or similar
Modified Paths:
--------------
trunk/workflow/lib/Workflow/Persister/RandomId.pm
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
------------------------------------------------------------------------------ [Less]
|
Posted
over 16 years
ago
by
jonasbn-Rn4VEauK AKRv LV9MX5uipxlwaOVQ5f< at >public.gmane.org
Revision: 414
http://perl-workflow.svn.sourceforge.net/perl-workflow/?rev=414&view=rev
Author: jonasbn
Date: 2008-12-20 16:53:27 0000 (Sat, 20 Dec 2008)
Log Message:
-----------
made constant a hardcoded number, addressing
... [More]
Perl::Critic policy [ValuesAndExpressions::ProhibitMagicNumbers]
Constant is a good candidate for propagation into a central package or similar
Modified Paths:
--------------
trunk/workflow/lib/Workflow/Persister.pm
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
------------------------------------------------------------------------------ [Less]
|
Posted
over 16 years
ago
by
jonasbn-Rn4VEauK AKRv LV9MX5uipxlwaOVQ5f< at >public.gmane.org
Revision: 415
http://perl-workflow.svn.sourceforge.net/perl-workflow/?rev=415&view=rev
Author: jonasbn
Date: 2008-12-20 16:57:32 0000 (Sat, 20 Dec 2008)
Log Message:
-----------
[ValuesAndExpressions::ProhibitMagicNumbers]
... [More]
addressed, might require readdressing and documenting later
Modified Paths:
--------------
trunk/workflow/t/perlcriticrc
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
------------------------------------------------------------------------------ [Less]
|
Posted
over 16 years
ago
by
jonasbn-Rn4VEauK AKRv LV9MX5uipxlwaOVQ5f< at >public.gmane.org
Revision: 416
http://perl-workflow.svn.sourceforge.net/perl-workflow/?rev=416&view=rev
Author: jonasbn
Date: 2008-12-20 17:01:13 0000 (Sat, 20 Dec 2008)
Log Message:
-----------
Added use of File::Slurp refactoring a problematic
... [More]
body of code addressing Perl::Critic policy [InputOutput::ProhibitJoinedReadline]
Modified Paths:
--------------
trunk/workflow/Build.PL
trunk/workflow/lib/Workflow/Persister/File.pm
trunk/workflow/t/perlcriticrc
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
------------------------------------------------------------------------------ [Less]
|
Posted
over 16 years
ago
by
jonasbn-Rn4VEauK AKRv LV9MX5uipxlwaOVQ5f< at >public.gmane.org
Revision: 417
http://perl-workflow.svn.sourceforge.net/perl-workflow/?rev=417&view=rev
Author: jonasbn
Date: 2008-12-20 17:05:03 0000 (Sat, 20 Dec 2008)
Log Message:
-----------
Added Ivan and Robert to AUTHORS section
Modified
... [More]
Paths:
--------------
trunk/workflow/lib/Workflow.pm
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
------------------------------------------------------------------------------ [Less]
|
Posted
over 16 years
ago
by
jonasbn-Rn4VEauK AKRv LV9MX5uipxlwaOVQ5f< at >public.gmane.org
Revision: 411
http://perl-workflow.svn.sourceforge.net/perl-workflow/?rev=411&view=rev
Author: jonasbn
Date: 2008-12-20 15:41:38 0000 (Sat, 20 Dec 2008)
Log Message:
-----------
Exchange calls to die and warn with croak and carp
... [More]
addressing Perl::Critic policy [ErrorHandling::RequireCarping]
Added requirement for Carp in Build.PL and added it's use in relevant packages
Modified Paths:
--------------
trunk/workflow/Build.PL
trunk/workflow/lib/Workflow/Action.pm
trunk/workflow/lib/Workflow/Condition.pm
trunk/workflow/lib/Workflow/Config/XML.pm
trunk/workflow/lib/Workflow/Factory.pm
trunk/workflow/lib/Workflow/Persister/DBI.pm
trunk/workflow/lib/Workflow/Persister/File.pm
trunk/workflow/lib/Workflow/Validator.pm
trunk/workflow/lib/Workflow.pm
trunk/workflow/t/perlcriticrc
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
---------------------------------------------------------- [Less]
|
Posted
over 16 years
ago
by
jonasbn-Rn4VEauK AKRv LV9MX5uipxlwaOVQ5f< at >public.gmane.org
Revision: 410
http://perl-workflow.svn.sourceforge.net/perl-workflow/?rev=410&view=rev
Author: jonasbn
Date: 2008-12-20 15:10:24 0000 (Sat, 20 Dec 2008)
Log Message:
-----------
Added Perl::Critic test and resource file, we
... [More]
currently have a lot of violations, please see the perlcriticrc which is located in t/ all violations are currently disabled and they will be enabled and addressed one at a time or we will document why we do not address them and we keep them disabled.
Added Paths:
-----------
trunk/workflow/t/04_critic.t
trunk/workflow/t/perlcriticrc
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
------------------------------------------------------------------------------ [Less]
|
Posted
over 16 years
ago
by
jonasbn-Rn4VEauK AKRv LV9MX5uipxlwaOVQ5f< at >public.gmane.org
Revision: 409
http://perl-workflow.svn.sourceforge.net/perl-workflow/?rev=409&view=rev
Author: jonasbn
Date: 2008-12-20 15:08:11 0000 (Sat, 20 Dec 2008)
Log Message:
-----------
Added old report
Added Paths:
-----------
... [More]
trunk/workflow/notes/test_coverage_0.32_1.txt
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
------------------------------------------------------------------------------ [Less]
|
Posted
over 16 years
ago
by
jonasbn-Rn4VEauK AKRv LV9MX5uipxlwaOVQ5f< at >public.gmane.org
Revision: 408
http://perl-workflow.svn.sourceforge.net/perl-workflow/?rev=408&view=rev
Author: jonasbn
Date: 2008-12-20 14:34:50 0000 (Sat, 20 Dec 2008)
Log Message:
-----------
Added Id keyword addressing
... [More]
[Miscellanea::RequireRcsKeywords] Perl::Critic policy
Modified Paths:
--------------
trunk/workflow/lib/Workflow/Validator/MatchesDateFormat.pm
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
------------------------------------------------------------------------------ [Less]
|
Posted
over 16 years
ago
by
jonasbn-Rn4VEauK AKRv LV9MX5uipxlwaOVQ5f< at >public.gmane.org
Revision: 407
http://perl-workflow.svn.sourceforge.net/perl-workflow/?rev=407&view=rev
Author: jonasbn
Date: 2008-12-20 13:14:19 0000 (Sat, 20 Dec 2008)
Log Message:
-----------
Updated, added a single point and removed another
... [More]
, which no longer made sense
Modified Paths:
--------------
trunk/workflow/TODO
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
------------------------------------------------------------------------------ [Less]
|