Netty Project

October 17, 2012 normanmaurer commented on pull request netty/netty#662 I think you are right.. directly running the 'Task' in the calling Thread is not good. I think if it was really shutdown we should throw an ... [More] RejectedExecutionException. So I think it would be better if we check with 'isShutdown()' if true we will throw the RejectedExecutionException. If not we try to execute the Tasks. This may also lead to the RejectedExecutionException but this is ok. WDYT ? [Less]

October 17, 2012 alex-berger opened pull request netty/netty#662 Fix race in AioEventLoopGroup 6 commits with 5 additions and 4 deletions

October 17, 2012 fbettag commented on issue netty/netty#656 didnt really get around to :/ sorry,wil try tonight again.

October 17, 2012 normanmaurer commented on commit netty/netty@543cb17acd @stuhood +1

October 17, 2012 stuhood commented on commit netty/netty@543cb17acd Looks good, and definitely cleans up the trace I was seeing. Thanks! #shipit

October 17, 2012 stuhood commented on commit netty/netty@543cb17acd Should probably add constants for the states?

October 17, 2012 AtKaaZ commented on issue netty/netty#598 You're right, I just thought SslHandler was supposed to(expected to) somehow do handshake automatically behind the scenes(in the securechat example before ... [More] your fixing commit), without manually having to call the handshake() method. Now it is all clear that it should've called handshake() manually, thank you! [Less]

October 17, 2012 AtKaaZ commented on issue netty/netty#644 Excellent work! Thank you so much!

October 17, 2012 trustin commented on issue netty/netty#65 Looks pretty good to me. Please issue a pull request when you are done, then we can do code review more closely. Cheers!

October 16, 2012 fbettag commented on issue netty/netty#654 we're basically just holding 2k longpolling connects (comet/websockets), the snoop example simply answers them, but does not hold them. maybe that's the key difference?