Open Hub
Open Hub

 Settings |  Report Duplicate

2
I Use This!
Activity Not Available

Commits : Listings

Analyzed 12 months ago. based on code collected over 1 year ago.
Jan 28, 2023 — Jan 28, 2024
Commit Message Contributor Files Modified Lines Added Lines Removed Code Location Date
Complete preliminalry implementation of the Cloneable interface for most major modules. The only unimplemented parts remain are descendants of Preprocessing, FeatureExtraction, and Classification classes. Some modules to not do complete clonning for all their members -- this is yet to look at and test. Clean up some code a bit more and apply more coding conventions in the places previously missed. Document the code more. Make more use of the StringBuffer class for likely hotspots and others.
mokhov
More... over 19 years ago
Adjust Eclipse project files to use JUnit.
mokhov
More... over 19 years ago
Similarly to testing.sh, enable assertions and reserve more memory for JVM.
mokhov
More... over 19 years ago
Fix bug #1395099. The duplicate IDs accumulated because the existence check was performed prior resotration of the IDs collection from disk. Swapping restore() and contains() order should fix the problem.
mokhov
More... over 19 years ago
Add compilation of the .bz2 packages and computation of the .md5 checksums. Overall, clean up the Makefile a bit.
mokhov
More... over 19 years ago
Instruct JVM to use 512Mb max Java partition of memory so that non-server machines no longer choke on OutOfMemory errors with the default 64Mb.
mokhov
More... over 19 years ago
After being traumatized by the performance of the toString() of Sample, update most of the toString() implementations to use StringBuffer. Will have review other places with intensive string concatenations as well.
mokhov
More... over 19 years ago
Bulk-replace a now slightly wrongly worded comment.
mokhov
More... over 19 years ago
Don't hint explicitly the garbage collection too often with System.gc() as many calls to this may actually significantly slow down the whole thing during the garbage collection runs.
mokhov
More... over 19 years ago
Fix the bug #1394533 in marf.math.Matrix's extend() for it not to set the member variables of dimensions right away and wait till completion as other methods were doing. Improve reporting in the assertion statement caused this. Enable assertion checks in MathTestApp so they get exposed sooner. Perform some addition code review of Matrix and fix a few incosisntencies and wrong comments. Add more garbage collector hints after potentially lots of tmp data allocations for matrix data arrays. Re-implement toString() more efficiently, using StringBuffer. Add a tad bit more comments.
mokhov
More... over 19 years ago
Fix the bug #1394533 in marf.math.Matrix's extend() for it not to set the member variables of dimensions right away and wait till completion as other methods were doing. Improve reporting in the assertion statement caused this. Enable assertion checks in MathTestApp so they get exposed sooner. Perform some addition code review of Matrix and fix a few incosisntencies and wrong comments. Add more garbage collector hints after potentially lots of tmp data allocations for matrix data arrays. Re-implement toString() more efficiently, using StringBuffer. Add a tad bit more comments.
mokhov
More... over 19 years ago
Add @see javadoc tags so older version (3.0) of Eclipse doesn't complain that the comment is incomplete.
mokhov
More... over 19 years ago
Reverse assertion checks as they were incorrectly set to assert the wrong thing. The assertions are to assert that certain condtion is true; and if it is not, then throw AssertionError.
mokhov
More... over 19 years ago
Reverse assertion checks as they were incorrectly set to assert the wrong thing. The assertions are to assert that certain condtion is true; and if it is not, then throw AssertionError.
mokhov
More... over 19 years ago
Provide an intermediate fix to compilation problem due to unhandled exceptions. Somehow missed...
mokhov
More... over 19 years ago
Advance Parsing code review for style, comments, and naming conventions.
mokhov
More... over 19 years ago
Eliminate unused variable.
mokhov
More... over 19 years ago
This mega commit includes a few large fixes and closes up a long standing bug #1273717. Specifically, SpeakerIdentApp has now the option "-aggr" to invoke the recently implemented FeatureExtractionAggregator for testing (for now as concatenation FFT and LPC until better alternatives are available). Debug FeatureExtractionAggregator so it actually works. This includes resetting the module parameters back to itself instead of just zeroing out because when MARF runs in the batch mode in the same JVM, we were able to run through only once successfully. Fix addition of the current thread to its group upon thread construction. Improve handling of the sub-module parameters with proper typechecks for the future. For all this to work, especially for cloning of the Preprocessing modules, the default constructors had to be made public. Did not entirely estimate consequences of this. The actual results of coupling FFT+LPC are rather pitiful at this point (need to implement F0 for more fruitful results).
mokhov
More... over 19 years ago
This mega commit includes a few large fixes and closes up a long standing bug #1273717. Specifically, SpeakerIdentApp has now the option "-aggr" to invoke the recently implemented FeatureExtractionAggregator for testing (for now as concatenation FFT and LPC until better alternatives are available). Debug FeatureExtractionAggregator so it actually works. This includes resetting the module parameters back to itself instead of just zeroing out because when MARF runs in the batch mode in the same JVM, we were able to run through only once successfully. Fix addition of the current thread to its group upon thread construction. Improve handling of the sub-module parameters with proper typechecks for the future. For all this to work, especially for cloning of the Preprocessing modules, the default constructors had to be made public. Did not entirely estimate consequences of this. The actual results of coupling FFT+LPC are rather pitiful at this point (need to implement F0 for more fruitful results).
mokhov
More... over 19 years ago
Complete first round of code review for the Compiler class. Reduce load on the Parser's constructor that was doing everything, and move some of it where it belongs in the Compiler. Mark a few TODO items in places to be done at a later time. Provide getters and setters for most members in the Parser class and rename most data members in accordance with the naming conventions.
mokhov
More... over 19 years ago
This concludes the first round of code review for the marf.nlp.Parsing.GrammarCompiler package of MARF. The Grammar class has been brought more-or-less to the style and comments with the rest of the package. Some public members were made protected and accessors were made for them and used where needed. In this commit, a few warnings and errors are eliminated due to a local variable hiding a member one and use of static members was corrected in places. Some more appropriate error handling is in place as well. Perform some tidy-ups and clean-ups along the way.
mokhov
More... over 19 years ago
Catch uncaught StorageException properly. Got forgotten in the previous commit.
mokhov
More... over 19 years ago
Complete preliminary code and comments review for GrammarAnalyzer and GrammarCompiler classes in terms of more accurate exception handling, javadoc comments, and naming. Fix a javadoc warning in marf.math.Matrix and rename all variables in accordance with the coding conventions in TransitionTable along the way.
mokhov
More... over 19 years ago
Advance TestPlugin application. Add an example of a FeatureExtraction plugin -- HashAddFeatureExctractor. Adjust Makefile so it actually compiles HashAddFeatureExctractor and HashClassifier as they are only references in the application by name. Add some documentation in the form of comments.
mokhov
More... over 19 years ago
Implement factories ClassificationFactory, PreprocessingFactory, and SampleLoaderFactory a-la FeatureExtractionFactory. Make FeatureExtractionFactory's constructor private for now as it is pointless to instantiate it. This cleans up MARF's pipeline code and the set of imports and captures proper exceptions and the functionality is more groupped where it belongs. As a result, complete implementation of the plugin system for sample loaders. Add a CUSTOM sound file type to be able to load plugins we don't know the type about. Enhance InvalidSampleFormatException and PreprocessingException with the standard constructor set they were lacking. Force WAVLoader to throw InvalidSampleFormatException in its default constructor to be in line with others, like SineLoader, as it is more sensical exception than StorageException. Hopefully, this does not break many client apps.
mokhov
More... over 19 years ago
Update the script to cope with the lack of enough quota and now build all intermediate stuff in /tmp instead.
mokhov
More... over 19 years ago
Complete initial implementation of the FeatureExtractionAggregator. It requires now extensive testing. Implement some other goodies along the way: FeatureExtractionFactory now groups all FeatureExtration modules creation more-or-less according to the corresponding Factory design pattern. This simplifies MARF's and FeatureExtractionAggregator's code; implement clone() for Sample and Preprocessing triggered by the need in the aggregator. Since cloning in Preprocessing is rather tricky, we clone the concrete class that may have an instance. In order to be able to create such an instance there should be a default constructor, so all preprocessing modules got a default protected constructor as a result. Additionally, augment IPreprocessing interface with the public clone() method so implementors have to be cloneable and those parts of the code that only operate by the means of this interface, can also have a public handle to the method. Make sure all that implements Serializable also implements Cloenable through IStorageManager. Implement two new constructors for Sample: Sample(int, double[]) and Sample(Sample). Document the relevant code. All these infrastructural changes require now extensive testing.
mokhov
More... over 19 years ago
Perform minor cosmetic clean up.
mokhov
More... over 19 years ago
Re-add ref. comment with a proper FQ name, so there are no more corresponding javadoc warnings.
mokhov
More... over 19 years ago
Begin implementation of FeatureExtractionAggregator to be able to concatenate features from different feature extraction modules as one feature vector.
mokhov
More... over 19 years ago